WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] Adds 'memory_sharing'

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Grzegorz Milos <Grzegorz.Milos@xxxxxxxxxx>
Subject: Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] Adds 'memory_sharing' option to domain config scripts. It passes domain id to
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 05 Jan 2010 16:08:22 +0000
Cc:
Delivery-date: Tue, 05 Jan 2010 08:09:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <ED3036A092A28F4C91B0B4360DD128EA3059B70B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acp+5GTB/4Aj0dgTSm6WX4GSErIP4APOm8DwAACedCs=
Thread-topic: [Xen-devel] RE: [Xen-changelog] [xen-unstable] Adds 'memory_sharing' option to domain config scripts. It passes domain id to
User-agent: Microsoft-Entourage/12.23.0.091001
On 05/01/2010 15:59, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> Hi, the changeset breaks guest creation in shadow mode:
> In image.py, xc.dom_set_memshr(self.vm.getDomid(), self.memory_sharing) would
> fail because
> in pyxc_dom_set_memshr():
>     if (xc_memshr_control(self->xc_handle, dom, enable) != 0)
>         return pyxc_error_to_exception();
> and in hypervisor's mem_sharing_domctl(),
>         case XEN_DOMCTL_MEM_SHARING_OP_CONTROL:
>         {
>             rc = 0;
>             if(!hap_enabled(d))
>                 return -EINVAL;  ----> this would fail xc.dom_set_memshr() so

Yes, we need a fix for this before 4.0-rc1 of course.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>