[Xen-devel] Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 09/12/2009 09:30, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove
> 
> In order to support HVM vcpu add/remove, we need set dsdt and madt
> infrastructure:
> 1. at dsdt, define ACPI objects and control methods (like _MAT, _EJ0, _STA)
> for processors;
> 2. at dsdt, define control method _L02 corresponding to SCI interrupts, build
> scan and notify method which trigger HVM acpi driver to add/remove cpu;
> 3. at madt, re-order madt subitems sequence, in order to make checksum
> locating more creditable (will not be influenced by madt change in the
> future). What is more, the re-order match normal madt sequence habit;

What's PROC_BASE, and what's APIC_MADT_PTR? No comments attached to them:
they look like random magic numbers.

DSDT code generation can be done in mk_dsdt.c, rather then addign
preprocessor stuff to the static part of the DSDT in dsdt.asl. So move stuff
there instead.

What's the MADT checksum stuff in the DSDT all about? Does the MADT really
have to stay consistent and checksummed after boot - I would have assumed
that it provides a boot-time snapshot of the system only, and would not be
looked at by the OSPM after boot. I haven't looked at the ASL code in detail
but I'll surely bet that the approach is fragile.

This needs a bunch more explanation and/or reworking before I would accept
it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel