Re: [Xen-devel] graphics passthrough with VT-d

Hi

Anybody available today? I know it's Saturday. :-)

-- 
Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering) 
Technical Support Engineer 
Information Technology Department
Asiasoft Online Pte Ltd
Tampines Central 1 #04-01 Tampines Plaza 
Singapore 529541
Republic of Singapore
Company Website: http://www.asiasoft.sg/
Mobile: +65-9648-9798
MSN: teoenming@xxxxxxxxxxx
Alma Maters: Singapore Polytechnic, National University of Singapore

On 08/29/2009 11:48 AM, Mr. Teo En Ming (Zhang Enming) wrote:

Dear All,

After applying Intel VGA passthrough patches 1, 2 and 3, I have no problems with "make xen", and "make install-xen". However, I have errors with "make tools".

Here is the error output:

msoft-float -I. -I.. -I../../../../tools/include -c -o build.o build.c
build.c: In function ‘construct_secondary_tables’:
build.c:194: error: ‘AmlCode_TPM’ undeclared (first use in this function)
build.c:194: error: (Each undeclared identifier is reported only once
build.c:194: error: for each function it appears in.)
make[8]: *** [build.o] Error 1
make[8]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware/hvmloader/acpi'
make[7]: *** [subdir-all-acpi] Error 2
make[7]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware/hvmloader'
make[6]: *** [subdirs-all] Error 2
make[6]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware/hvmloader'
make[5]: *** [subdir-all-hvmloader] Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware'
make[4]: *** [subdirs-all] Error 2
make[4]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools/firmware'
make[2]: *** [subdir-install-firmware] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg-vgapt/tools'
make: *** [install-tools] Error 2

There is an undeclared identifier in tools/firmware/hvmloader/acpi/build.c source code. Could you guys help me resolve this issue?

I had no problems compiling xen 3.5-unstable before applying the Intel vga passthrough patches and before installing the Intel ACPI Component Architecture compiler.

I have also attached Intel graphics passthrough patches 1, 2 and 3 for your convenience here.

Thank you very much.

Hope I can get this working during the weekends.

-- 
Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering) 
Technical Support Engineer 
Information Technology Department
Asiasoft Online Pte Ltd
Tampines Central 1 #04-01 Tampines Plaza 
Singapore 529541
Republic of Singapore
Company Website: http://www.asiasoft.sg/
Mobile: +65-9648-9798
MSN: teoenming@xxxxxxxxxxx
Alma Maters: Singapore Polytechnic, National University of Singapore

On 08/29/2009 10:17 AM, Mr. Teo En Ming (Zhang Enming) wrote:

Hi Tim,

I thought it should be gfx_passthru=2 in domU config?

-- 
Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering) 
Technical Support Engineer 
Information Technology Department
Asiasoft Online Pte Ltd
Tampines Central 1 #04-01 Tampines Plaza 
Singapore 529541
Republic of Singapore
Mobile: +65-9648-9798
MSN: teoenming@xxxxxxxxxxx
Alma Maters: Singapore Polytechnic, National University of Singapore

On 08/29/2009 06:42 AM, Tim Moore wrote:

Teo,

I have also performed the same exercise as yourself and I now have successfully compiled all 3x patches into Xen, Qemu and the BIOS File Loading in the hvmloader, this all compiles find on my system. Suggest you do a "make clean" on the tools and start again !

After booting with the patched xen-unstable and adding the gfx-passthru=1 parameter to my HVM DomU, as I suspected - it still doesn't work.

I have both a 9500GT and GTX260(primary) in my Intel DX58SO machine, tried passing through either device and my primary display locks up ! (included hiding with pci-stub)

I verified that the DomU was functional beforehand, as It also booted successfully without the gfx-passthru parameter (and a vncviewer/cirrus display)

Unfortunately, I can't debug further as my Primary display corrupts as soon as the DomU starts. I did notice that in "xm debug" the "Loading Gfx BIOS File.." message was displayed and the DomU did continue to initialise the BIOS tables and such before finally locking. I then (blindly) typed on a corrupt Dom0 console and managed to start kdm and login, so the Dom0 was not completely trashed. But then after a few minutes, the machine totally froze and had to hit the reset switch.

I`m no specialist but this looks like the VGA BIOS Re-initialisation is playing havoc with the DomU and possibly the Dom0 graphics. I notice that both are also using IRQ11 which could play a major part. Furthermore, there was a lot of debug output in the qemu and xend.log indicating Base Address Register invalid access and therefore it seems there may be a second obstacle.

Hope you have a better success than me !

For now, I would try re-compiling a fresh xen-unstable with carefully applied patches .. oh! and don't forget to enable the pci-stub driver for Dom0 (it's not selected by default)

Tim

From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Mr. Teo En Ming (Zhang Enming)
Sent: 28 August 2009 21:14
To: enming.teo@xxxxxxxxxxxxxxx
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; 'Lin, Ben Y'; 'Kay, Allen M'; 'Jean Guyader'; Keir.Fraser@xxxxxxxxxxxxx; weidong.han@xxxxxxxxx; bengheng@xxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 2/2] graphics passthrough with VT-d

After applying the 1st and 2nd patch to xen-unstable successfully, I examined the source codes Makefile and hvmloader.c in tools/firmware/hvmloader, compared them to Weidong's 3rd patch and I generated my own 3rd patch. Then I used my own generated 3rd patch to apply patching for loading vga bios from firmware file.

Here is my own generated 3rd patch instead of using Weidong's 3rd patch:

--- Makefile    2009-08-29 03:24:52.413083774 +0800

+++ Makefile    2009-08-29 03:29:12.763299633 +0800

@@ -50,6 +50,7 @@

 roms.h: ../rombios/BIOS-bochs-latest ../vgabios/VGABIOS-lgpl-latest.bin \

        ../vgabios/VGABIOS-lgpl-latest.cirrus.bin ../etherboot/eb-roms.h

        sh ./mkhex rombios ../rombios/BIOS-bochs-latest > roms.h

+       sh ./mkhex vgabios_pt ../vgabios/vgabios-pt.bin >> roms.h

        sh ./mkhex vgabios_stdvga ../vgabios/VGABIOS-lgpl-latest.bin >> roms.h

        sh ./mkhex vgabios_cirrusvga \

                ../vgabios/VGABIOS-lgpl-latest.cirrus.bin >> roms.h

--- hvmloader.c 2009-08-29 03:26:06.911085797 +0800

+++ hvmloader.c 2009-08-29 03:31:43.172084995 +0800

@@ -688,9 +688,9 @@

         vgabios_sz = round_option_rom(sizeof(vgabios_stdvga));

         break;

     case VGA_pt:

-        printf("Loading VGABIOS of passthroughed gfx ...\n");

-        vgabios_sz =

-            round_option_rom((*(uint8_t *)(VGABIOS_PHYSICAL_ADDRESS+2)) * 512);

+       printf("Loading Gfx Video BIOS from file ...\n");

+       memcpy((void *)VGABIOS_PHYSICAL_ADDRESS, vgabios_pt, sizeof(vgabios_pt));

+       vgabios_sz = round_option_rom(sizeof(vgabios_pt));

         break;

     default:

         printf("No emulated VGA adaptor ...\n");

I can "make xen" successfully but when I proceeded to "make tools", errors were encountered.

Please see attached error output. How can I solve this problem?

--

Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering)

Technical Support Engineer

Information Technology Department

Asiasoft Online Pte Ltd

Tampines Central 1 #04-01 Tampines Plaza

Singapore 529541

Republic of Singapore

Mobile: +65-9648-9798

MSN: teoenming@xxxxxxxxxxx

Alma Maters: Singapore Polytechnic, National University of Singapore

On 08/29/2009 12:59 AM, Mr. Teo En Ming (Zhang Enming) wrote:

OK I believe the 3rd patch is not incomplete but there's a white space issue when I copied the code from the mailing list into my vi.

See http://www.htdig.org/mail/2000/11/0167.html

When I used the -l flag to patch using the 3rd patch, the number of errors was reduced.

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# patch -l -p1 < intel-gfx-passthru-patch-3.patch

patching file tools/firmware/hvmloader/Makefile

patching file tools/firmware/hvmloader/hvmloader.c

Hunk #1 FAILED at 688.

1 out of 1 hunk FAILED -- saving rejects to file tools/firmware/hvmloader/hvmloader.c.rej

Now patching tools/firmware/hvmloader/Makefile is successful but patching tools/firmware/hvmloader/hvmloader.c still failed.

--

Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering)

Technical Support Engineer

Information Technology Department

Asiasoft Online Pte Ltd

Tampines Central 1 #04-01 Tampines Plaza

Singapore 529541

Republic of Singapore

Mobile: +65-9648-9798

MSN: teoenming@xxxxxxxxxxx

Alma Maters: Singapore Polytechnic, National University of Singapore

On 08/28/2009 11:55 PM, Mr. Teo En Ming (Zhang Enming) wrote:

Dear Weidong,

A big big thanks for the vga passthrough patches for xen 3.5-unstable!!! These are eagerly anticipated patches. As I did not study computer science and computer architecture, I won't be able to write those patches you guys at Intel wrote.

I applied the following patches xen-gfx-passthrough.patch and qemu-gfx-passthrough.patch to xen 3.5-unstable without issues.

Then I tried to apply the 3rd patch you provided at http://lists.xensource.com/archives/html/xen-devel/2009-08/msg01047.html

I saved the following code

<CODE>

diff -r 494be76c1ad9 tools/firmware/hvmloader/Makefile

--- a/tools/firmware/hvmloader/Makefile Thu Aug 27 16:54:33 2009 +0800

+++ b/tools/firmware/hvmloader/Makefile Thu Aug 27 17:22:01 2009 +0800

@@ -50,6 +50,7 @@ roms.h: ../rombios/BIOS-bochs-latest ../

 roms.h: ../rombios/BIOS-bochs-latest ../vgabios/VGABIOS-lgpl-latest.bin \

    ../vgabios/VGABIOS-lgpl-latest.cirrus.bin ../etherboot/eb-roms.h

    sh ./mkhex rombios ../rombios/BIOS-bochs-latest > roms.h

+   sh ./mkhex vgabios_pt ../vgabios/vgabios-pt.bin >> roms.h

    sh ./mkhex vgabios_stdvga ../vgabios/VGABIOS-lgpl-latest.bin >> roms.h

    sh ./mkhex vgabios_cirrusvga \

        ../vgabios/VGABIOS-lgpl-latest.cirrus.bin >> roms.h

diff -r 494be76c1ad9 tools/firmware/hvmloader/hvmloader.c

--- a/tools/firmware/hvmloader/hvmloader.c  Thu Aug 27 16:54:33 2009 +0800

+++ b/tools/firmware/hvmloader/hvmloader.c  Thu Aug 27 17:23:00 2009 +0800

@@ -688,9 +688,9 @@ int main(void)

         vgabios_sz = round_option_rom(sizeof(vgabios_stdvga));

         break;

     case VGA_pt:

-        printf("Loading Gfx Video BIOS from 0xC0000 ...\n");

-        vgabios_sz =

-            round_option_rom((*(uint8_t *)(VGABIOS_PHYSICAL_ADDRESS+2)) * 512);

+         printf("Loading Gfx Video BIOS from file ...\n");

+         memcpy((void *)VGABIOS_PHYSICAL_ADDRESS, vgabios_pt,

sizeof(vgabios_pt));

+         vgabios_sz = round_option_rom(sizeof(vgabios_pt));

         break;

     default:

         printf("No emulated VGA adaptor ...\n");

</CODE>

as intel-gfx-passthru-patch-3.patch and then I tried to apply the patch to xen 3.5-unstable. I got errors. I think it's because the 3rd patch you provided is incomplete.

Here's my patching process:

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# find . -name vgabios

./tools/firmware/vgabios

./.hg/store/data/tools/firmware/vgabios

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# cp ~enming/vgabios-pt.bin tools/firmware/vgabios/

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# ls tools/firmware/vgabios/

biossums.c  clext.c      Makefile  TODO                 vbe.h            vgabios.h       vgatables.h

BUGS        COPYING      Notes     vbe.c                vbetables-gen.c  vgabios-pt.bin

ChangeLog   dataseghack  README    vbe_display_api.txt  vgabios.c        vgafonts.h

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# pwd

/usr/src/xen-unstable.hg-vgapt

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# wget http://lists.xensource.com/archives/html/xen-devel/2009-08/bincPiiAf0QWg.bin

--2009-08-28 23:18:21--  http://lists.xensource.com/archives/html/xen-devel/2009-08/bincPiiAf0QWg.bin

Resolving lists.xensource.com... 70.42.241.110

Connecting to lists.xensource.com|70.42.241.110|:80... connected.

HTTP request sent, awaiting response... 200 OK

Length: 12565 (12K) [application/octet-stream]

Saving to: `bincPiiAf0QWg.bin'

100%[======================================================================>] 12,565      30.7K/s   in 0.4s

2009-08-28 23:18:22 (30.7 KB/s) - `bincPiiAf0QWg.bin' saved [12565/12565]

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# mv bincPiiAf0QWg.bin xen-gfx-passthrough.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# vi xen-gfx-passthrough.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# patch < xen-gfx-passthrough.patch

can't find file to patch at input line 4

Perhaps you should have used the -p or --strip option?

The text leading up to this was:

--------------------------

|diff -r 5d7e7a250267 tools/firmware/hvmloader/config.h

|--- a/tools/firmware/hvmloader/config.h      Wed Aug 26 18:28:44 2009 +0800

|+++ b/tools/firmware/hvmloader/config.h      Thu Aug 27 16:54:24 2009 +0800

--------------------------

File to patch: ^C

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# ex xen-gfx-passthrough.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# patch -p1 < xen-gfx-passthrough.patch

patching file tools/firmware/hvmloader/config.h

patching file tools/firmware/hvmloader/hvmloader.c

patching file tools/libxc/ia64/xc_ia64_hvm_build.c

patching file tools/libxc/xc_hvm_build.c

patching file tools/libxc/xc_linux.c

patching file tools/libxc/xenctrl.h

patching file tools/libxc/xenguest.h

patching file tools/python/xen/lowlevel/xc/xc.c

patching file tools/python/xen/xend/XendConfig.py

Hunk #1 succeeded at 174 (offset -1 lines).

patching file tools/python/xen/xend/image.py

Hunk #1 succeeded at 780 (offset -6 lines).

Hunk #3 succeeded at 895 (offset -6 lines).

patching file tools/python/xen/xm/create.py

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# wget http://lists.xensource.com/archives/html/xen-devel/2009-08/binglLqkeq4Rj.bin

--2009-08-28 23:21:35--  http://lists.xensource.com/archives/html/xen-devel/2009-08/binglLqkeq4Rj.bin

Resolving lists.xensource.com... 70.42.241.110

Connecting to lists.xensource.com|70.42.241.110|:80... connected.

HTTP request sent, awaiting response... 200 OK

Length: 9841 (9.6K) [application/octet-stream]

Saving to: `binglLqkeq4Rj.bin'

100%[======================================================================>] 9,841       24.3K/s   in 0.4s

2009-08-28 23:21:36 (24.3 KB/s) - `binglLqkeq4Rj.bin' saved [9841/9841]

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# mv binglLqkeq4Rj.bin qemu-gfx-passthrough.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# vi qemu-gfx-passthrough.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# find . -name hw

./tools/ioemu-remote/hw

./.hg/store/data/tools/ioemu/hw

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# mv qemu-gfx-passthrough.patch tools/ioemu-remote/

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# cd tools/ioemu-remote/

[root@fedora11-x86-64-host ioemu-remote]# patch -p1 < qemu-

qemu-aio.h                  qemu-img.c                  qemu-sockets.c

qemu-binfmt-conf.sh         qemu-img.texi               qemu-tech.texi

qemu-char.c                 qemu-lock.h                 qemu-timer.h

qemu-char.h                 qemu-log.h                  qemu-tool.c

qemu-common.h               qemu-malloc.c               qemu-xen.h

qemu-doc.texi               qemu-nbd.c

qemu-gfx-passthrough.patch  qemu-nbd.texi

[root@fedora11-x86-64-host ioemu-remote]# patch -p1 < qemu-gfx-passthrough.patch

patching file hw/pass-through.c

patching file hw/pass-through.h

patching file hw/pc.c

patching file vl.c

[root@fedora11-x86-64-host ioemu-remote]# cd ..

[root@fedora11-x86-64-host tools]# cd ..

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# vi intel-gfx-passthru-patch-3.patch

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# patch -p1 < intel-gfx-passthru-patch-3.patch

patching file tools/firmware/hvmloader/Makefile

Hunk #1 FAILED at 50.

1 out of 1 hunk FAILED -- saving rejects to file tools/firmware/hvmloader/Makefile.rej

patching file tools/firmware/hvmloader/hvmloader.c

patch: **** malformed patch at line 24: sizeof(vgabios_pt));

[root@fedora11-x86-64-host xen-unstable.hg-vgapt]# vi intel-gfx-passthru-patch-3.patch

For everybody's convenience, I have attached intel-gfx-passthru-patch-3.patch and the firmware for my nVidia GeForce 8400 GS PCI Express x16 graphics card in this email.

Please help me complete intel-gfx-passthru-patch-3.patch as I really need it.

Thank you very much!!!

--

Mr. Teo En Ming (Zhang Enming) Dip(Mechatronics Engineering) BEng(Hons)(Mechanical Engineering)

Technical Support Engineer

Information Technology Department

Asiasoft Online Pte Ltd

Tampines Central 1 #04-01 Tampines Plaza

Singapore 529541

Republic of Singapore

Mobile: +65-9648-9798

MSN: teoenming@xxxxxxxxxxx

Alma Maters: Singapore Polytechnic, National University of Singapore

This patch supports basic gfx passthrough on QEMU:

  - disable emulated VGA adpater if there is passthroughed gfx

  - register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx

Signed-off-by: Ben Lin <ben.y.lin@xxxxxxxxx>

Signed-off-by: Weidong Han <weidong.han@xxxxxxxxx>

No virus found in this incoming message.

Checked by AVG - www.avg.com

Version: 8.5.409 / Virus Database: 270.13.69/2328 - Release Date: 08/27/09

18:02:00

No virus found in this outgoing message.

Checked by AVG - www.avg.com

Version: 8.5.409 / Virus Database: 270.13.71/2330 - Release Date: 08/27/09

18:02:00

_______________________________________________

Xen-devel mailing list

Xen-devel@xxxxxxxxxxxxxxxxxxx

http://lists.xensource.com/xen-devel

_______________________________________________

Xen-devel mailing list

Xen-devel@xxxxxxxxxxxxxxxxxxx

http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] graphics passthrough with VT-d