[Xen-devel] Re: [PATCH] Fix bzip2/lzma compilation/linking problems in tools/libxc/Makefile

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

I fixed this differently. See c/s 20116.

 -- Keir

On 23/08/2009 18:08, "Pasi Kärkkäinen" <pasik@xxxxxx> wrote:

> Hello,
> 
> The attached patch fixes two problems in tools/libxc/Makefile in xen-unstable.
> 
> 1) libxenguest.so.3.4.0 is linked from *.opic files, so the -DHAVE_BZLIB
> -DHAVE_LZMA
> CFLAGS need to be added to xc_dom_bzimageloader.opic aswell.
> 
> 2) There was an ordering/dependency problem with .zlib.deps file generation
> resulting 
> in missing CFLAGS for xc_dom_bzimageloader.o|.opic compilation.
> 
> ie. sometimes (for example during rpmbuild) this is what happened:
> 
> grep: .zlib.deps: No such file or directory
>  - BZIP2 decompression supported
>  - LZMA decompression supported
> 
> The .zlib.deps file generation was done _after_ the CFLAGS += stuff was ran..
> obviously resulting in missing BZIP2/LZMA support.
> 
> I fixed this by making the .zlib.deps generation being the first thing to run.
> 
> -- Pasi



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel