WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] xen pm trace utility cleanup

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] xen pm trace utility cleanup
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: Wed, 19 Aug 2009 17:10:11 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 19 Aug 2009 02:11:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcogrNS5+OzW1Uz8RFy/TCcH509seA==
Thread-topic: [PATCH] xen pm trace utility cleanup
xenpm trace utility gtraceview cleanup

- add gtraceview help info on how to get raw data by xentrace
- make trace_exit_reason compiled in non-debug mode. trace_exit_reason can be 
enable/disabled by xentrace at runtime, so no need to disable it at build time.

Signed-off-by: Yu Ke <ke.yu@xxxxxxxxx>

diff -r 8b0f1f37e145 tools/misc/gtracestat.c
--- a/tools/misc/gtracestat.c
+++ b/tools/misc/gtracestat.c
@@ -442,7 +442,7 @@ void show_help(void)
 {
     show_version();
     printf("tracestat <trace.data> [-vhdselbcmau]\n");
-    printf("  trace.data       raw data from xentrace\n");
+    printf("  trace.data       raw data got by 'xentrace -e 0x80f000 
trace.dat'\n");
     printf("  -v / --version   show version message\n");
     printf("  -h / --help      show this message\n");
     printf("  -d / --digest    digest mode, more variables to specify.\n");
diff -r 8b0f1f37e145 tools/misc/gtraceview.c
--- a/tools/misc/gtraceview.c
+++ b/tools/misc/gtraceview.c
@@ -542,7 +542,8 @@ void show_help(void)
 {
     show_version();
     printf("gtraceview <trace.data> [--version] [--help]\n");
-    printf("  trace.data   raw data from xentrace\n");
+    printf("  trace.data   raw data got by "
+           "'xentrace -e 0x80f000 trace.dat'\n");
     printf("  --version    show version information\n");
     printf("  --help       show this message\n");
     printf("For more help messages, please press 'h' in the window\n");
diff -r 8b0f1f37e145 xen/arch/x86/acpi/cpu_idle.c
--- a/xen/arch/x86/acpi/cpu_idle.c
+++ b/xen/arch/x86/acpi/cpu_idle.c
@@ -198,7 +198,6 @@ static struct {
 
 static inline void trace_exit_reason(u32 *irq_traced)
 {
-#ifdef DEBUG
     if ( unlikely(tb_init_done) )
     {
         int i, curbit;
@@ -215,7 +214,6 @@ static inline void trace_exit_reason(u32
             curbit = find_next_bit((const unsigned long *)irr_status, 256, 
curbit + 1);
         }
     }
-#endif
 }
 
 static void acpi_processor_idle(void)

Attachment: gtraceview.patch
Description: gtraceview.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] xen pm trace utility cleanup, Yu, Ke <=