[Xen-devel] Re: [PATCH]xend: pass-through: fix "xm pci-list-assi

On Wed, Jul 29, 2009 at 10:26:21AM +0800, Cui, Dexuan wrote:
> Simon Horman wrote:
> >> pci_dict_to_bdf_str(new_dev)) +        pci_name =
> >> '%04x:%02x:%02x.%x' % \ +          (parse_hex(new_dev['domain']),\
> >> +           parse_hex(new_dev['bus']),\
> >> +           parse_hex(new_dev['slot']),\
> >> +           parse_hex(new_dev['func']))
> > 
> >   You should be able to use pci_name = pci_dict_to_bdf_str(new_dev)
> >   here instead of the above 5 lines.
> Hi Simon,
> Agree.  Your suggestion is good. 
> 
> 
> > 
> >> +        if pci_name in get_all_assigned_pci_devices():
> >> +            raise VmError("failed to assign device %s that has"
> >> +                          " already been assigned to other domain."
> >> % pci_str) 
> > 
> >   Should pci_str be pci_name in the line above ?
> Thanks a lot for the careful review!
> Actually I corrected the mistake in my side, but I didn't send the latest 
> version... :-(
> I'll ack the fix you sent out just now.

Thanks.

In practice I'm not sure that error condition can ever fire,
it seemed to be caught earlier on my system.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

[Xen-devel] Re: [Xen-changelog] [xen-unstable] xend: pass-through: device state in xenstore may be null, Simon Horman

Next by Date:

Re: [Xen-devel] KeyError: 'use_tmp_kernel' with -unstable, Andreas Florath

Previous by Thread:

[Xen-devel] RE: [PATCH]xend: pass-through: fix "xm pci-list-assignable-devices' for pv_guest, Cui, Dexuan

Next by Thread:

[Xen-devel] Re: [Xen-users] Domain0 cannot connect to the net while domainU can.How to make the domain0 go to the internet., SamuelCheng

Indexes:

[Date] [Thread] [Top] [All Lists]