WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH V2] passthrough: deliver IRQs even if VCPU#0 is h

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH V2] passthrough: deliver IRQs even if VCPU#0 is halted
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Fri, 10 Jul 2009 18:27:41 +0900
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 10 Jul 2009 02:28:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C67CB870.F476%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7khbxlgi5o.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <C67CB870.F476%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Keir Fraser writes:
> Just target the i8259_target, and don't bother with the MP efficiency
> changes.

Sure. Attached. kdump works fine with this patch.
I was a little bit worried about i8259_target pointing the halted VCPU#0.

Thanks,
Kouya

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r 20743a0a4ac5 xen/drivers/passthrough/io.c
--- a/xen/drivers/passthrough/io.c      Thu Jul 09 17:06:40 2009 +0100
+++ b/xen/drivers/passthrough/io.c      Fri Jul 10 18:12:44 2009 +0900
@@ -378,7 +378,11 @@ int hvm_do_IRQ_dpci(struct domain *d, un
     if ( pt_irq_need_timer(dpci->mirq[mirq].flags) )
         set_timer(&dpci->hvm_timer[domain_irq_to_vector(d, mirq)],
                   NOW() + PT_IRQ_TIME_OUT);
-    vcpu_kick(d->vcpu[0]);
+
+    if ( d->arch.hvm_domain.i8259_target != NULL )
+        vcpu_kick(d->arch.hvm_domain.i8259_target);
+    else if ( d->vcpu != NULL )
+        vcpu_kick(d->vcpu[0]);
 
     return 1;
 }
@@ -437,7 +441,10 @@ void hvm_dirq_assist(struct vcpu *v)
     struct hvm_irq_dpci *hvm_irq_dpci = d->arch.hvm_domain.irq.dpci;
     struct dev_intx_gsi_link *digl;
 
-    if ( !iommu_enabled || (v->vcpu_id != 0) || (hvm_irq_dpci == NULL) )
+    if ( !iommu_enabled || (hvm_irq_dpci == NULL))
+        return;
+
+    if ( (v->vcpu_id != 0) && (v != d->arch.hvm_domain.i8259_target) )
         return;
 
     for ( irq = find_first_bit(hvm_irq_dpci->dirq_mask, d->nr_pirqs);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel