WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Tue, 16 Jun 2009 10:52:52 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 16 Jun 2009 01:54:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A3774610200007800005DF7@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C64E9416.CDC3%keir.fraser@xxxxxxxxxxxxx> <200906151733.02897.Christoph.Egger@xxxxxxx> <4A3774610200007800005DF7@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Tuesday 16 June 2009 10:30:57 Jan Beulich wrote:
> >>> Christoph Egger <Christoph.Egger@xxxxxxx> 15.06.09 17:33 >>>
> >
> >@@ -174,8 +177,11 @@ wakeup_64:
> >         mov     $(__HYPERVISOR_DS64), %eax
> >         mov     %eax, %ds
> >
> >-        # long jump to return point, with cs reload
> >-        rex64 ljmp    *ret_point(%rip)
> >+        /* Continue with wakeup in the high-level wakeup code.
> >+         * Reload cs there.
> >+         */
> >+        movq    ret_point(%rip), %rbx
> >+        jmp     *%rbx
> >
> >         .align 8
> > ret_point:
>
> Why do you add a comment ("Reload cs here") here that is not in sync with
> the changed code?

Re-read: You missed the "t"
:)

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel