| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI
|
To: |
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI |
|
From: |
Jeff Garzik <jeff@xxxxxxxxxx> |
|
Date: |
Thu, 28 May 2009 15:51:33 -0400 |
|
Cc: |
Chris Wright <chrisw@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ky Srinivasan <ksrinivasan@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Greg KH <gregkh@xxxxxxx> |
|
Delivery-date: |
Fri, 29 May 2009 08:39:51 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<alpine.LFD.2.01.0905271436140.3435@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> <1243409850-21577-18-git-send-email-jeremy@xxxxxxxx> <alpine.LFD.2.01.0905270829530.3435@xxxxxxxxxxxxxxxxxxxxx> <20090527211828.GA6166@xxxxxxx> <alpine.LFD.2.01.0905271436140.3435@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.21 (X11/20090320) |
Linus Torvalds wrote:
On Wed, 27 May 2009, Ingo Molnar wrote:
hm, i have to concur. Too often it ends up splitting attention away
from the title of the commit. I do reject (or fix up) bad impact
lines - will stop doing them altogether if you think there's a net
downside to them ...
I actually think that if there is a good reason for them, they can stay.
Just don't make it one of those "every commit that goes through me has to
have one".
Pu another way: if they actually add value in highlighting the commits
that _should_ stand out, then hey, by all means, keep such ones. I would
not at all object if it was an issue of
[ Impact: fix bugzilla entry 455123 ]
or
[ Impact: fix user-triggerable oops ]
Ideally "Impact" is pointless if you are otherwise writing a clear,
concise commit description. "Fixes user-triggerable oops" on a line by
itself is clear enough, and is how I've been writing descriptions for a
while.
People with the urge to add "Impact:" to every commit wind up either
being redundant, or for small patches, having the entire ex-Subject
commit description be "Impact: blah blah blah"
If IOW, if the impact is not already clear, you're doing something
wrong, and "Impact" is not necessarily going to fix that.
Jeff
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home