WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 17/17] xen: disable MSI

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 17/17] xen: disable MSI
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 27 May 2009 08:34:22 -0700 (PDT)
Cc: Chris Wright <chrisw@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ky Srinivasan <ksrinivasan@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Greg KH <gregkh@xxxxxxx>
Delivery-date: Wed, 27 May 2009 14:00:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1243409850-21577-18-git-send-email-jeremy@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> <1243409850-21577-18-git-send-email-jeremy@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.01 (LFD 1184 2008-12-16)

On Wed, 27 May 2009, Jeremy Fitzhardinge wrote:
> 
> [ Impact: prevent MSI subsystem from crashing ]

Grr.

I looked at several of these impact lines, and they were _all_ totally 
misleading.

Please, guys. Stop with the F*CKING impact lines already. Add them if they 
are obvious, but don't make them this idiotic "do an impact line whether 
or not it makes sense".

I hate them. They are stupid. 90% of all the impact lines I see are either 
(a) misleading or (b) totally inane and pointless. 

In this case, we would have been a LOT BETTER OFF with having just a 
better header line that said "xen: disable MSI to avoid crash" or 
something like that. But no. THAT F*CKING IMPACT LINE apparently meant 
that Jeremy just turned off his brain, and made _both_ the header line and 
the Impact: line be non-descriptive.

Really. Stop it. Ingo, start saying "no" to people, at least for impact 
lines that do not make sense. It adds _nothing_, and it actually detracts 
from real content, because just the inanity of them delutes the whole 
meaning of it.

                Linus

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>