WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] minios: replace mktime implementation

To: Nigel Gamble <nigel@xxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] minios: replace mktime implementation
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 27 May 2009 20:05:11 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 27 May 2009 12:05:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <3EE061F6-1589-4725-89CF-0780FA867F6F@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acne+Ah5hTqQQ+pDSrC8SrUzFJZJWAABgZzy
Thread-topic: [Xen-devel] [PATCH] minios: replace mktime implementation
User-agent: Microsoft-Entourage/12.17.0.090302
On 27/05/2009 19:21, "Nigel Gamble" <nigel@xxxxxxx> wrote:

>> I checked and going back in time in 2003 entry.S in MiniOS has been
>> rewritten to be able to license MiniOS under BSD, so we should be
>> fine.
> 
> Yes, it looks like this is true of x86_32.S, but it looks to me as if
> x86_64.S was missed, because it is still clearly derived from Linux,
> not BSD.

Yes, you're quite obviously right. Stefano, we should at least remove all
the commented out Linux code (most of which is CFI_* stack unwinding
directives) and probably expand out many of the macros, most of which are
used only once anyway. Plus rename/reorg where possible in line with
x86_32.S. That's maybe an hour's work at most and I'd be comfortable
claiming copyright on the result, or at least I'm certain it would be as
clean as x86_32.S at that point (Which was never clean-room rewritten).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>