WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Performance overhead of paravirt_ops on native identifie

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: Performance overhead of paravirt_ops on native identified
From: Chuck Ebbert <cebbert@xxxxxxxxxx>
Date: Thu, 21 May 2009 18:42:33 -0400
Cc: Nick Piggin <npiggin@xxxxxxx>, "Xin, Xiaohui" <xiaohui.xin@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Linux, Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>
Delivery-date: Tue, 26 May 2009 07:17:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A0B62F7.5030802@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat, Inc.
References: <4A0B62F7.5030802@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 13 May 2009 17:16:55 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Paravirt patching turns all the pvops calls into direct calls, so
> _spin_lock etc do end up having direct calls.  For example, the compiler
> generated code for paravirtualized _spin_lock is:
> 
> <_spin_lock+0>:               mov    %gs:0xb4c8,%rax
> <_spin_lock+9>:               incl   0xffffffffffffe044(%rax)
> <_spin_lock+15>:      callq  *0xffffffff805a5b30
> <_spin_lock+22>:      retq
> 
> The indirect call will get patched to:
> <_spin_lock+0>:               mov    %gs:0xb4c8,%rax
> <_spin_lock+9>:               incl   0xffffffffffffe044(%rax)
> <_spin_lock+15>:      callq <__ticket_spin_lock>
> <_spin_lock+20>:      nop; nop                /* or whatever 2-byte nop */
> <_spin_lock+22>:      retq
> 

Can't those calls be changed to jumps?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>