WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] [xm, xend] passthrough: Add assigned_or_requeste

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] [xm, xend] passthrough: Add assigned_or_requested_vslot()
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 26 May 2009 18:41:58 +1000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 26 May 2009 01:42:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <74C9DDD2F3997Bkanno.masaki@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090526063342.GA7824@xxxxxxxxxxxx> <74C9DDD2F3997Bkanno.masaki@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, May 26, 2009 at 04:24:05PM +0900, Masaki Kanno wrote:
> Hi Simon,
> 
> Great!!  Your patch is of importance.
> If without your patch, we cannot start domains.  I found a problem 
> about starting domains.  The reproduction operations of the problem 
> are as follows.
> 
> Step to Reproduce:
>   1. xm start <domain>
>   2. xm pci-attach <domain> **:**.* *
>   3. Shutdown guest OS on <domain>
>   4. xm start <domain> ---> fail
> 
> Your patch has solved the problem.

Great!

> Trivial comment:
>   The following line includes Tab indent.

Sorry, I will fix that and repost.

> Index: xen-unstable.hg/tools/python/xen/xm/main.py
> ===================================================================
> --- xen-unstable.hg.orig/tools/python/xen/xm/main.py  2009-05-26 14:
> 37:15.000000000 +1000
> +++ xen-unstable.hg/tools/python/xen/xm/main.py       2009-05-26 14:38:36.
> 000000000 +1000
> @@ -2167,18 +2167,12 @@ def xm_pci_list(args):
>  
>      has_vslot = False
>      for x in devs:
> -        if x.has_key('vslot'):
> -            if x['vslot'] == "0x%s" % AUTO_PHP_SLOT_STR:
> -                x['vslot'] = '-'
> -            else:
> -                has_vslot = True
> -        elif not x.has_key('requested_vslot'):
> -            x['vslot'] = '-'
> -        elif x['requested_vslot'] == "0x%s" % AUTO_PHP_SLOT_STR:
> +     vslot = assigned_or_requested_vslot(x)     <------------ here!!
> +        if int(vslot, 16) == AUTO_PHP_SLOT:
>              x['vslot'] = '-'
>          else:
> +            x['vslot'] = vslot
>              has_vslot = True
> -            x['vslot'] = x['requested_vslot']
>  
>      if has_vslot:
>          hdr_str = 'VSlt domain   bus   slot   func'

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>