WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] Fix xm pci-detach for inactive devices

To: Simon Horman <horms@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [patch] Fix xm pci-detach for inactive devices
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Tue, 26 May 2009 14:03:38 +0900
Cc: Zhai Edwin <edwin.zhai@xxxxxxxxx>
Delivery-date: Mon, 25 May 2009 22:04:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090526043821.GA24218@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090526043821.GA24218@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Simon,

I agree to your thought.

Acked-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Tue, 26 May 2009 14:38:24 +1000, Simon Horman wrote:

>In the case where a device is attached to an inactive domain
>and then removed before the domain is activated it won't have
>a vslot assigned, but it should still be valid to remove it.
>
>I don't think that there are any other cases where vslot can
>be invalid.
>
>Lightly tested
>
>Cc: Zhai Edwin <edwin.zhai@xxxxxxxxx>
>Cc: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
>Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
>
>Index: xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py
>===================================================================
>--- xen-unstable.hg.orig/tools/python/xen/xend/XendDomainInfo.py       2009-05
-26
> 14:37:15.000000000 +1000
>+++ xen-unstable.hg/tools/python/xen/xend/XendDomainInfo.py    2009-05-26 14:
>37:18.000000000 +1000
>@@ -1130,9 +1130,6 @@ class XendDomainInfo:
>         if devnum >= pci_len:
>             raise VmError("Device @ vslot 0x%x doesn't exist." % (vslot))
> 
>-        if vslot == AUTO_PHP_SLOT:
>-            raise VmError("Device @ vslot 0x%x doesn't support hotplug." %
> (vslot))
>-
>         # Check the co-assignment.
>         # To pci-detach a device D from domN, we should ensure: for each 
>DD in the
>         # list of D's co-assignment devices, DD is not assigned (to domN).
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel