WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Question about the dynamic sizing of the PCI hole

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Question about the dynamic sizing of the PCI hole
From: Tom Rotenberg <tom.rotenberg@xxxxxxxxx>
Date: Mon, 25 May 2009 12:24:42 +0300
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 25 May 2009 02:25:08 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=Wrgakx+JAjg8a5mUz/4NzUftA6nPhT6BVTa5TdNr6RE=; b=cxJfWYKYTIwz23g2FIK8KE4NqG73sWBTWPKF/FfmF8PFF59bK86imSWvh2Kq8JXUt8 Kt7LaLrt77jgk6Xktp18z2gauDMEMeQpcuxazQTXgu5H6gNVkjBsx/81yrk0OZPd4jlO DaP7MhQg/cxWIx1ivsOyzMLjxYu6csiZKs39w=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UQ+2qQc55ZlcUcipvM+9twK+PTtK/GHKDfZg4o3j77ClksPTniay2Ze8OC49raJaTl ngUYOqL/6BMwh5ex/yhJm3OhWArQzo5nfvLTFW6KG6l+MMIhigH+8iNJs8SCt8Txxrky o2ZYJDbnDNDrIvT2IYbj7Z3qeygrM8si3aomY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6401FF6.BB9B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <8686c3cd0905250201u5eb546a5n35b7600e4b264feb@xxxxxxxxxxxxxx> <C6401FF6.BB9B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
And, won't we have any problem if we dynamically size the PCI hole, and not update it in the DSDT we give for the HVM (in the DSDT it's always 0xf0000...)?

2009/5/25 Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
On 25/05/2009 10:01, "Tom Rotenberg" <tom.rotenberg@xxxxxxxxx> wrote:

> I am reviewing the code of the hvmloader from Xen 3.4, and i saw that in
> changeset 19021, there was a patch which added the ability to dynamically size
> the PCI hole. I have seen that this patch calculates the total memory size,
> but i failed to understand the following lines:
>
> while ( (mmio_total > (pci_mem_end - pci_mem_start)) &&
>             ((pci_mem_start << 1) != 0) )
>         pci_mem_start <<= 1;
>
> It looks as if the pci mem start will be increased if there isn't enough space
> for the PCI devices, although, as far as i understand, it should be decreased
> (so the PCI hole will be enlarged). So, shouldn't it be: "pci_mem_start >> =
> 1" ?

Leading bits of this 32-bit value are 1s. Hence left shift is what we want.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel