WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functi

To: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 06/10] x86/PCI: Enable scanning of all pci functions
From: Alex Chiang <achiang@xxxxxx>
Date: Thu, 14 May 2009 18:07:25 -0600
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Joerg Roedel <joerg.roedel@xxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>, Alex Nixon <alex.nixon@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>
Delivery-date: Fri, 15 May 2009 06:33:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090514121513.198ada4e@jbarnes-g45>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1242164891-3859-1-git-send-email-jeremy@xxxxxxxx> <1242164891-3859-7-git-send-email-jeremy@xxxxxxxx> <20090513095535.140134e1@jbarnes-g45> <4A0AFE84.2040805@xxxxxxxx> <20090513102316.5ef3ce4e@jbarnes-g45> <4A0C66DB.9020707@xxxxxxxx> <20090514121513.198ada4e@jbarnes-g45>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17+20080114 (2008-01-14)
* Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>:
> On Thu, 14 May 2009 11:45:47 -0700
> Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> 
> > Jesse Barnes wrote:
> > > Anyway it's not a big deal, this code is already ugly (a 0 define
> > > for all arches?  why?) so you shouldn't have to spend too much time
> > > cleaning it up.
> > >   
> > 
> > OK, how's this as a delta (I can fold it into the previous patch if 
> > you're OK with it):
> > 
> > Subject: [PATCH] pci: add HAVE_ARCH_PCIBIOS_SCAN_ALL_FNS
> > 
> > Jesse objected to the "#undef pcibios_scan_all_fns"'s ugliness,
> > so replace it with the more common HAVE_ARCH_ idiom.
> > 
> > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> > Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> 
> That's slightly better.  It looks like we should just get rid of
> pcibios_scan_all_fns altogether, but this is fine for now.

It's been on my TODO list for a while now, but then holiday and
now surgery got in the way.

/ac


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>