WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest c

To: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] disallow duplicate pci device strings in guest config file
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 15 May 2009 12:44:37 +0100
Cc:
Delivery-date: Fri, 15 May 2009 04:44:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <EADF0A36011179459010BDF5142A457501C990A939@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnVUKywB4Q5NpcfRuKxiLcTkuwu4gAAdlgc
Thread-topic: [PATCH] disallow duplicate pci device strings in guest config file
User-agent: Microsoft-Entourage/12.17.0.090302
Why is the right answer not: Don't do that, then?

 -- Keir

On 15/05/2009 12:31, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> When we specify duplicate pci device strings in guest config file, like
> pci=['01:00.0', '01:00.0'], or  pci=['01:00.0', '0000:01:00.0'], or
> pci=['01:00.0', '0000:01:00.0@7'],
> xend doesn't detect this case and passes the pci string to ioemu and ioemu
> invokes register_real_device() twice for the same physical device and this
> could cause unexpected behavior.
> 
> The patch detects this case and makes the domain construction fail.
> 
> Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel