WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 1/9] xen: make sure swiotlb allocation is physica

To: Joerg Roedel <joro@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1/9] xen: make sure swiotlb allocation is physically contigious
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 11 May 2009 11:42:42 -0700
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>
Delivery-date: Mon, 11 May 2009 11:45:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090511135532.GA8671@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1241741842-7966-1-git-send-email-jeremy@xxxxxxxx> <1241741842-7966-2-git-send-email-jeremy@xxxxxxxx> <20090511135532.GA8671@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Joerg Roedel wrote:
+}
+
+void *swiotlb_alloc(unsigned order, unsigned long nslabs)
+{
+       /* Never called on x86.  Warn, just in case. */

Can't this function be removed completly then?

The swiotlb code contains a static call, which never ends up being executed, so there has to be something to be called. But you're right that there's no particular reason for this warning unless someone starts to call swiotlb_alloc in the future.

I'd briefly discussed the idea of eliminating the distinction between boot and post-boot swiotlb allocation, but it looks tricky to implement.

+
+       if (xen_create_contiguous_region((unsigned long)buf,
+                                        order, 0xffffffff))
                                                DMA_32BIT_MASK?

OK (ditto other mentions).

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>