WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [tip:x86/xen] x86: use flush_tlb_others to implement flu

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb_all, fix
From: Ingo Molnar <mingo@xxxxxxx>
Date: Mon, 11 May 2009 17:42:02 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-tip-commits@xxxxxxxxxxxxxxx" <linux-tip-commits@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>
Delivery-date: Mon, 11 May 2009 08:42:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1242056394.29990.94.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1241797927.15972.51.camel@xxxxxxxxxxxxxxxxxxxxxx> <tip-636afdbe85d50d9b88f5283b5e6d0f8518431aac@xxxxxxxxxxxxxx> <20090511131230.GA32693@xxxxxxx> <1242054041.29990.88.camel@xxxxxxxxxxxxxxxxxxxxxx> <20090511151151.GA3267@xxxxxxx> <1242056394.29990.94.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote:

> in any case I would guess that the fix is:
> 
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -87,6 +87,7 @@
>  #include <asm/cacheflush.h>
>  #include <asm/processor.h>
>  #include <asm/bugs.h>
> +#include <asm/tlbflush.h>
>  
>  #include <asm/system.h>
>  #include <asm/vsyscall.h>

Guessing is not enough - please review the prototype position. Is it 
available on all configs? It is not ...

But even the proper fix runs into that smp_processor_id() bug i just 
posted.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>