WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 02/18] xen: hook io_apic read/write operations

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 02/18] xen: hook io_apic read/write operations
From: Ingo Molnar <mingo@xxxxxxx>
Date: Mon, 11 May 2009 13:19:04 +0200
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
Delivery-date: Mon, 11 May 2009 04:19:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A05A408.3020006@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1241730883-4917-1-git-send-email-jeremy@xxxxxxxx> <1241730883-4917-3-git-send-email-jeremy@xxxxxxxx> <20090509084201.GF3656@xxxxxxx> <20090509084324.GA5158@xxxxxxx> <4A05A408.3020006@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

>> And on a higher level, i still dont see why you dont do the whole 
>> Xen thing under an irqchip. There should be no extra crappy 
>> checks in native code.
>
> Hm, every time you see this code, you always have this 
> quasi-Pavlovian response.

Yep, my reaction to ugly code is pretty predictable, and 
(hopefully!) repeatable. So calling it Pavlovian is an implicit 
(albeit, i suspect, unintended ;-) compliment.

> You say "use an irqchip".  I say:
>
>    * We already use irqchip
>    * but most of the interesting IO apic accesses (routing) are not
>      done via the irqchip interface
>    * so irqchip doesn't help

I dont see the problem. All APIs within Linux are kept minimalistic 
and are extended on the fly, on an on-demand basis.

> And then you don't reply.  And then you raise it again.
>
> I would *always* prefer to hook into an interface like irqchip 
> rather than gouge into the code, but I really think that irqchip 
> isn't that interface.  If you have a more specific suggestion or 
> proposal I'll happily follow it up, but repeating "you should use 
> an irqchip" isn't getting anywhere.

Well, my main task at this stage is to point out ugly code. I might 
be able to do research for you and come up with a plan for you, but 
that's really a courtesy in general and is not always possible for 
maintainers. You might argue "of all possible solutions this is the 
cleanest" but i havent seen you make that point.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel