|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to	crea
 
| 
To:  | 
"Daniel P. Berrange" <berrange@xxxxxxxxxx> | 
 
| 
Subject:  | 
Re: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to	create img | 
 
| 
From:  | 
Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> | 
 
| 
Date:  | 
Tue, 5 May 2009 18:19:52 +0100 | 
 
| 
Cc:  | 
"Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>,	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>,	"Li, Xin" <xin.li@xxxxxxxxx>, "Zhang, Yang" <yang.zhang@xxxxxxxxx> | 
 
| 
Delivery-date:  | 
Tue, 05 May 2009 10:20:20 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
In-reply-to:  | 
<20090505142823.GA12530@xxxxxxxxxx> | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
References:  | 
<10C63FAD690C13458F0B32BCED571F1412A2344B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<E88DD564E9DC5446A76B2B47C3BCCA155C2840AE@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<E88DD564E9DC5446A76B2B47C3BCCA155C30EA6D@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<18936.29628.474866.270018@xxxxxxxxxxxxxxxxxxxxxxxx>	<18938.49959.734396.339825@xxxxxxxxxxxxxxxxxxxxxxxx>	<EADF0A36011179459010BDF5142A4575154E1104@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<EADF0A36011179459010BDF5142A4575154E133F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>	<18944.19070.403451.993996@xxxxxxxxxxxxxxxxxxxxxxxx>	<20090505142823.GA12530@xxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
 
 
Daniel P. Berrange writes ("Re: [Xen-devel][PATCH]ioemu:fix up error when using 
qemu-img-xen to create img"):
> On Tue, May 05, 2009 at 03:17:34PM +0100, Ian Jackson wrote:
> > Upstream qemu have fixed this problem in a half-hearted way and
> > evidently their qemu-img is still vulnerable.  We have changed the
> > format-determination code in block.c so that any attempt to autodetect
> > a format never returns `raw'; that means that any vulnerable code
> > anywhere is instantly fixed although it may break some existing usages
> > in cases where we haven't properly plumbed through a specification of
> > the image format.
> 
> Wasn't the upstream change to add a '-F baseimage_format' enough to
> allow the flaw to be avoided when creating new images ? Or are you
> attempting to prevent the issue, even when -F is not used ?
Yes, upstream have introduced -F but only in the main branch, and not
the stable branch we're basing Xen 3.4 on.  So yes, this problem will
go away when I pull after the Xen 3.4 release.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 |   
 
 | 
    | 
  
  
    |   | 
    |