WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] do_domctl and EAGAIN

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] do_domctl and EAGAIN
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Tue, 07 Apr 2009 10:19:20 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Apr 2009 01:19:54 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1239092457; x=1270628457; h=from:sender:reply-to:subject:date:message-id:to:cc: mime-version:content-transfer-encoding:content-id: content-description:resent-date:resent-from:resent-sender: resent-to:resent-cc:resent-message-id:in-reply-to: references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:list-owner:list-archive; z=From:=20Juergen=20Gross=20<juergen.gross@xxxxxxxxxxxxxx> |Subject:=20Re:=20[Xen-devel]=20do_domctl=20and=20EAGAIN |Date:=20Tue,=2007=20Apr=202009=2010:19:20=20+0200 |Message-ID:=20<49DB0C88.50403@xxxxxxxxxxxxxx>|To:=20Keir =20Fraser=20<keir.fraser@xxxxxxxxxxxxx>|CC:=20"xen-devel@ lists.xensource.com"=20<xen-devel@xxxxxxxxxxxxxxxxxxx> |MIME-Version:=201.0|Content-Transfer-Encoding:=207bit |In-Reply-To:=20<C600C746.80DD%keir.fraser@xxxxxxxxxxxxx> |References:=20<C600C746.80DD%keir.fraser@xxxxxxxxxxxxx>; bh=I334mcs27AFpMCV/f19L7S7Af9qLtMgsKE/x57yN2Lw=; b=OPFBOm+NTXomLukuO+Rb7Xs3n3jVeyqf44Ua8a+y6ELuxM+GGHGSzsZX uahrR+GnkSEM2nJ4PLdWLReTsCm8zm+YpE8NpL8WSQk3SiDWCYydOB26k My3Mk3rgYIL9SeSet103l1Ka3H2OdIyc7pcZ7WEa7NDJVgHiLxxrJBQNI MSoQj2SSsE6eK1CHuO9LeXyOLeaAsffiodfM6v3q9JmIFjQ+SIvM6DoEi UNZVWU/NLTP00L7q6rAdG61MDRqob;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:X-Enigmail-Version:Content-Type: Content-Transfer-Encoding; b=PIN8YJLHWFHznTA/sJgNcTbt1P4jckKDH3tWWTCieeSFQmDVGa7IGONn 6Mj9LFnlegDeES5xkYpgtOeki9tsPBJq4z11fBgcRj//MEmYhQk8aY+i3 FgczXaoslhxKU88KGxZDxuqfSskEIkl9vtvkY9eVZNNpRXIRmQ5Muw//+ Cqu+7NS4bFNqatlSmK9QaBKiLJ9oSBt1ow1dmIy8PGni7h2fnUXuS8n+Z I2LH+fs4IY9QYfAikEpQkAuAddqfj;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C600C746.80DD%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <C600C746.80DD%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
Keir Fraser wrote:
> On 07/04/2009 08:41, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:
> 
>> Keir Fraser wrote:
>>> Only DOMCTL_destroydomain returns EAGAIN. No domctl returns EINTR.
>> do_domctl uses ioctl.
>> ioctl can return EINTR if a signal is caught.
> 
> Our privcmd hypercall ioctl() is non-blocking and hence I don't think can
> return EINTR. In fact ioctl() is used in loads of places throughout our
> toolstack and in qemu, and I don't think EINTR is checked by any caller, nor
> is EINTR mentioned in the ioctl man page.

On my system the ioctl man page does mention it:

ERRORS
       Under the following general conditions, ioctl() shall fail if:

       EBADF  The fildes argument is not a valid open file descriptor.

       EINTR  A signal was caught during the ioctl() operation.


In the non-blocking case this might be irrelevant. Are you sure this is no
issue in any case?


Juergen

-- 
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 636 47950
Fujitsu Technolgy Solutions               e-mail: juergen.gross@xxxxxxxxxxxxxx
Otto-Hahn-Ring 6                        Internet: ts.fujitsu.com
D-81739 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel