Re: [Xen-devel] [PATCH] Do not set page's count_info directly

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 12:32 +0000 on 05 Mar (1236256358), Gianluca Guida wrote:
> Yes, that's correct. I find, though, (count_info & PGC_count_mask !=
> 0) as a check if the page is a shadow *very* confusing. Could you
> define a macro with something like page_is_a_shadow_page() and hide
> this mm.c dirty secret?

The check doesn't tell you it's a shadow page -- it just tells you it's
*not* allocated in another way.  Checking with the mask is OK here,
perhaps with a comment change.

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel