This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 8/9] tmem: invocations of tmem code fromexisting

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 8/9] tmem: invocations of tmem code fromexisting xen code
From: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Date: Fri, 6 Feb 2009 06:25:04 -0800 (PST)
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Feb 2009 06:26:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <498C0B95.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> You use do_tmem_op() directly for 32-on-64 mode, which I 
> think is wrong
> given the definition of the interface structure (you'd 
> minimally have to use
> XEN_GUEST_HANDLE_64 in order for this to be correct). But 
> even if it was
> right (or if you make it so), it would in my opinion be a 
> requirement to
> assure it is by adding a respective entry to xen/include/xlat.lst.

I have to admit I am baffled by all aspects of XEN_GUEST_HANDLE
and just hacked on it until the code worked.  I would be grateful
for either an explanation of xen/include/xlat.lst or a pointer
to an explanation... or, even better, hints on how to fix
my code to properly use XEN_GUEST_HANDLE_64.

I would like the code to definitely support 32-on-64 and
64-on-64.  32-on-32 is optional; because of xenheap limitations
it is largely a toy, but still useful for testing.

All of this works today, but possibly only due to hackery,
which I am eager to fix properly if told how.


Xen-devel mailing list