WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups

To: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 06 Feb 2009 12:00:24 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Feb 2009 04:00:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18828.8851.985067.577542@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmIUn4J1INn37CAq0SS0Y3Mr3tJ+g==
Thread-topic: [Xen-devel] [PATCH 3/5] setup_irq/request_irq/free_irq fixups
User-agent: Microsoft-Entourage/12.15.0.081119
On 06/02/2009 11:44, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx> wrote:

>> My reading of the patch was that you simply pushed irq_to_vector()
>> out into every caller. I therefore just took the ->shutdown() fix
>> for free_irq() and dropped the rest. I checked in the rest of your
>> patches.
> 
> Hmmm... yeah.  The patch probably didn't make this very clear since
> some of the callers just invoke the function with the vector as the
> parameter (and hence these callers were not included in the patch).
> 
> Anyhow, if you drop the vector parameter the IOMMU related interrupts
> will most certainly not work since we no longer update the
> irq_to_vector() array with those entries.

Oh yes, also your patch would certainly have broken IA64, since you did not
update its irq.c, nor does IA64 even have an irq_to_vector() macro.

I suggest you do something like:
 * Rename the functions to {setup,request,free}_irq_vector().
 * Make {setup,request,free}_irq() be simple wrappers around the above.
 * Only use the new function names for the IOMMU callers for now.
 * Think about how to not break IA64.

And make a new patch, against c/s 19180 or later.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>