WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] vpt periodic timer and vhpet

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] vpt periodic timer and vhpet
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 06 Feb 2009 08:24:14 +0000
Cc:
Delivery-date: Fri, 06 Feb 2009 00:24:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <0A882F4D99BBF6449D58E61AAFD7EDD606C4EBA6@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcmIDre9/q8/gfi9SwCvDbdwMkw2gwAJZOT9
Thread-topic: [Xen-devel] vpt periodic timer and vhpet
User-agent: Microsoft-Entourage/12.15.0.081119
On 06/02/2009 03:55, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Just noted vpt create_periodic_time is now changed to require
> two parameters: period and delta, by 18694 which ports vhpet
> to vpt framework. I'm not quite clear the necessity here. It doesn't
> matter whether 1st expiration must be accurately hit. vhpet
> main counter and per-channel comparators are updated only
> when guest tries to read. Is there any special tricks on hpet
> since all other periodic timers are simply filling same value for
> period and delta?
> 
> I ask because we're considering some proactive timer alignment
> besides existing range timer, while above change seems to implicate
> something that we may neglect.

See the changeset that introduced the delta (18694), see the changeset
comment and the comment above use of create_periodic_time() in hpet.c.
Decide if you agree, and if you don't then ask the author, cc'ing the list.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>