WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies
From: Ingo Molnar <mingo@xxxxxxx>
Date: Thu, 5 Feb 2009 18:34:30 +0100
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, x86@xxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Tejun Heo <htejun@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Delivery-date: Thu, 05 Feb 2009 09:35:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <498B226A.2020900@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4983AC87.5000304@xxxxxxxx> <498A87B5.3020808@xxxxxxxxx> <20090205150028.GD23903@xxxxxxx> <498B0E13.7060604@xxxxxxxxx> <498B226A.2020900@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Tejun Heo wrote:
>> Impact: style cleanup
>>
>> Make the following sytle cleanups.
>>
>> * drop unnecessary //#include from xen-asm_32.S
>>   
> Fine.
>> * compulsive adding of space after comma
>>   
> Fine.
>> * reformat multiline comments
>>   
>
> I don't really like what you've done here.  There are two problems:
>
>    * If you're going to convert comments of the form
>
>      /* This is a small comment which
>         happens to be longer than a line. */
>          
>
>      then you should convert it to full winged-style, rather than just
>      sticking '*' on the front of the second line.
>    * All the big block comments look crowded and cramped now, which
>      makes them harder to read and maintain.  All those '*'s are just
>      visual noise. (They make a bit more sense in C code to distinguish
>      comment from code, but asm code looks so different from comment
>      that they're not necessary here.)
>
> But Ingo's already pulled it, so I guess I'm stuck with it.

i pulled it and i already fixed all the proper winged style comments as 
well. Could you double-check the end result please?

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>