WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] fbfront: Improve diagnostics when kthread_run() fail

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] fbfront: Improve diagnostics when kthread_run() fails
From: Markus Armbruster <armbru@xxxxxxxxxx>
Date: Mon, 02 Feb 2009 10:17:22 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 02 Feb 2009 01:17:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <498009CC.1000101@xxxxxxxxxxxxxx> (Akio Takebe's message of "Wed\, 28 Jan 2009 16\:31\:24 +0900")
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <497E784B.7060003@xxxxxxxxxxxxxx> <497ED10A.76E4.0078.0@xxxxxxxxxx> <498009CC.1000101@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)
Failure is reported with xenbus_dev_fatal(..."register_framebuffer"),
which was already suboptimal before it got moved away from
register_framebuffer(), and is outright misleading now.

Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>

diff -r 26ddc59c674d drivers/xen/fbfront/xenfb.c
--- a/drivers/xen/fbfront/xenfb.c       Fri Jan 30 10:54:10 2009 +0000
+++ b/drivers/xen/fbfront/xenfb.c       Mon Feb 02 10:12:54 2009 +0100
@@ -211,7 +211,7 @@
                return;
 
        mutex_lock(&info->mm_lock);
-       
+
        spin_lock_irqsave(&info->dirty_lock, flags);
        if (info->dirty){
                info->dirty = 0;
@@ -837,7 +837,7 @@
                        if (IS_ERR(info->kthread)) {
                                info->kthread = NULL;
                                xenbus_dev_fatal(dev, PTR_ERR(info->kthread),
-                                               "register_framebuffer");
+                                               "xenfb_thread");
                        }
                }
                break;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>