 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] grant table interface addition?
| To: | "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] grant table interface addition? |
| From: | "Jan Beulich" <jbeulich@xxxxxxxxxx> |
| Date: | Fri, 31 Oct 2008 16:13:16 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 31 Oct 2008 09:13:21 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C530DCB5.28A35%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <490B37E3.76E4.0078.0@xxxxxxxxxx> <C530DCB5.28A35%keir.fraser@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 31.10.08 17:03 >>> >On 31/10/08 15:52, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > >> Looking at that code I see some other potential issue, though: >> GRANT_PTE_FLAGS include PAGE_USER for x86-64, but the generated >> pte is passed through adjust_guest_l1e(), so without >> GNTMAP_application_map we'd get global kernel mappings. Am I wrong >> here? > >GRANT_PTE_FLAGS should include _PAGE_GUEST_KERNEL then? No, it should uniformly include neither _PAGE_USER nor _PAGE_GUEST_KERNEL. _PAGE_USER gets set when GNTMAP_application_map is specified, and based on this setting of _PAGE_USER, adjust_guest_l1e() will set either _PAGE_GUEST_KERNEL or _PAGE_GLOBAL. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] grant table interface addition?, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] grant table interface addition?, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] grant table interface addition?, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] grant table interface addition?, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
