WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Question about memory allocation on NUMA node.

To: Andre Przywara <andre.przywara@xxxxxxx>, Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Question about memory allocation on NUMA node.
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 29 Oct 2008 10:17:11 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 29 Oct 2008 03:17:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081029105921.61117f53@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack5r4Fpv9PPAqWiEd2PmgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Question about memory allocation on NUMA node.
User-agent: Microsoft-Entourage/11.4.0.080122
On 29/10/08 09:59, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

>> What do you think?
> I would revert to giving a valid domain pointer as the first parameter
> instead of duplicating the code in alloc_domheap_pages().
> Patch attached.

This is not correct, as the page must not be mappable and modifiable by the
guest. Yuji's suggestion of specifying MEMF_node() is actually correct, so
that's what I'll check in.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>