WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH, RFC] i386: highmem access assistance hypercalls

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH, RFC] i386: highmem access assistance hypercalls
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Mon, 20 Oct 2008 15:27:03 +0100
Cc:
Delivery-date: Mon, 20 Oct 2008 07:27:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48F8CB2D.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ackyv+ufKkIGSJ6zEd2bHQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH, RFC] i386: highmem access assistance hypercalls
User-agent: Microsoft-Entourage/11.4.0.080122
On 17/10/08 16:28, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> The hypervisor patch is below (using temporary numbers for the newly
> added sub-hypercalls), the Linux patch didn't change over the first
> submission (if the patch here is acceptable, I'll create a version
> that applies to the 2.6.18 tree).
> 
> Opinions?

I'm fine in principle. A cursory glance at the substance of the patch
indicates that there are some secondary portions which could be discarded or
broken out into separate patches: the constifying of unmap_domain_page*()
and the addition of FIX_HOLE to fixmap.h. Please divide up as appropriate
and re-send.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel