[Xen-devel] [PATCH] fix CPUID mask option handling

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

c/s 18402 added command line options to AMD-specific code duplicating
ones already existing in Intel code. The generic command line parser
didn't support this scenario for integer options, however.

Additionally, the options added were using the same option string for
two different purposes.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-09-19/xen/arch/x86/cpu/amd.c
===================================================================
--- 2008-09-19.orig/xen/arch/x86/cpu/amd.c      2008-09-01 08:34:25.000000000 
+0200
+++ 2008-09-19/xen/arch/x86/cpu/amd.c   2008-10-15 14:25:45.000000000 +0200
@@ -37,8 +37,8 @@ static unsigned int opt_cpuid_mask_ecx, 
 integer_param("cpuid_mask_ecx", opt_cpuid_mask_ecx);
 integer_param("cpuid_mask_edx", opt_cpuid_mask_edx);
 static unsigned int opt_cpuid_mask_ext_ecx, opt_cpuid_mask_ext_edx;
-integer_param("cpuid_mask_ecx", opt_cpuid_mask_ext_ecx);
-integer_param("cpuid_mask_edx", opt_cpuid_mask_ext_edx);
+integer_param("cpuid_mask_ext_ecx", opt_cpuid_mask_ext_ecx);
+integer_param("cpuid_mask_ext_edx", opt_cpuid_mask_ext_edx);
 
 static inline void wrmsr_amd(unsigned int index, unsigned int lo, 
                unsigned int hi)
Index: 2008-09-19/xen/common/kernel.c
===================================================================
--- 2008-09-19.orig/xen/common/kernel.c 2008-01-17 09:25:56.000000000 +0100
+++ 2008-09-19/xen/common/kernel.c      2008-10-15 14:38:48.000000000 +0200
@@ -75,8 +75,7 @@ void cmdline_parse(char *cmdline)
                 strlcpy(param->var, optval, param->len);
                 break;
             case OPT_UINT:
-                *(unsigned int *)param->var =
-                    simple_strtol(optval, (const char **)&optval, 0);
+                *(unsigned int *)param->var = simple_strtol(optval, NULL, 0);
                 break;
             case OPT_BOOL:
             case OPT_INVBOOL:




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel