WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC][PATCH] eliminate extra tb_init_done check

To: "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] eliminate extra tb_init_done check
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 15 Oct 2008 08:17:43 +0100
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Delivery-date: Wed, 15 Oct 2008 00:18:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <8FED46E8A9CA574792FC7AACAC38FE7701AD289D7A@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ackujh/1zJ1t6mC1QvuJDyrbjliW1wAB/1xs
Thread-topic: [Xen-devel] [RFC][PATCH] eliminate extra tb_init_done check
User-agent: Microsoft-Entourage/11.4.0.080122
On 15/10/08 07:20, "Lu, Guanqun" <guanqun.lu@xxxxxxxxx> wrote:

> Two corner conditions are left untouched. One is the assembly in entry.S,
> the other is the check of tb_init_done not immediately followed by
> __trace_var.
> 
> Or more aggressively, we can eliminate all the extra checks, make tb_init_done
> a static variable, and rename __trace_var to trace_var which looks more like
> a right interface name.

The macros check tb_init_done before calling __trace_var() to try and reduce
the cost of the common case (tracing disabled) as far as possible. Hence we
avoid a function call and computation of some arguments to that function.

I don't know if we've actually measured teh performance win from this. If we
have, George would know about it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>