WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] qemu-xen: Fix PV segfault

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] qemu-xen: Fix PV segfault
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Wed, 02 Jul 2008 09:54:16 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 02 Jul 2008 00:57:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18538.27111.959001.890654@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4863E1F6.60909@xxxxxxx> <18538.27111.959001.890654@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (X11/20071114)
Ian Jackson schrieb:
> Kevin Wolf writes ("[PATCH] qemu-xen: Fix PV segfault"):
>> Don't access cur_cpu with CONFIG_DM, for PV machines it is NULL.
> 
> I'm not sure I understand the execution context here properly.  Is
> this for blktap ?  It would be better to make cur_cpu be set to some
> sensible value.

No, this is completely independent of blktap. Currently, PV machines
just don't have a virtual cpu in qemu - in contrary to FV machines which
call a complete pc_machine.init() during their initialization.

Maybe you're right and it would be better to assign even PV machines a
cpu, but I'm not sure what other functionality this implies to
implement. I'll try to look into this.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel