RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Thanks Keir,

I will fix gcc-specific attributes in public header files ASAP.

I add a local variable 'a' in common/domain.c, since need to do '
xen_processor_pmbits &= (~a);'
If we directly use ' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)' may
result in some align issue if xen_processor_pmbits is not 32bits
variable.
So I add 'a' with same type as 'xen_processor_pmbits'.

Regards,
Jinsong

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, May 13, 2008 4:56 PM
To: Liu, Jinsong; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> Get ACPI Px from dom0 and chose Px controller
> 
> Add platform op hypercall case to get ACPI Px info from dom0.
> Chose Px controller from dom0 (cpufreq=dom0-kernel)
> or hypervisor (cpufreq=xen-cpufreq)

No gcc-specific attributes in the public header files. This means no
__attribute__((packed)). Please fix that.

Also why declare a local variable 'a' in your changes to
common/domain.c?

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel