Re: [Xen-devel] [RFC] PVFB: Add refresh period to XenStore parameters?

[Markus Armbruster <armbru@xxxxxxxxxx>]

Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> writes:

> Markus Armbruster, le Fri 09 May 2008 10:43:15 +0200, a écrit :
[...]
>> >  union xenfb_in_event
>> >  {
>> >      uint8_t type;
>> > +    struct xenfb_refresh_period refresh_period;
>> 
>> Time unit?
>
> There is one in the structure above.

I was confused.

>> I'd be tempted to use a frequency instead of a period, just because
>> that doesn't require a special value for "no updates".  Strictly a
>> matter of taste.
>
> The "problem" of an integer frequency is that it does not permit a
> period of more than one second, which may become a limit in some odd
> situations (thousands of VMs waking every second?)
>
> Samuel

Okay.  Any convenient encoding for the values you're interested in
should do, as long as it's documented clearly.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel