WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Greater than 16 xvd devices for blkfront

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] Greater than 16 xvd devices for blkfront
From: Chris Wright <chrisw@xxxxxxxxxxxx>
Date: Wed, 7 May 2008 09:40:31 -0700
Cc: Chris Lalancette <clalance@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 07 May 2008 09:40:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080507034726.GC2121@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <48209705.4030005@xxxxxxxxxx> <20080507015502.GA2121@xxxxxxxxxx> <20080507034726.GC2121@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
* Daniel P. Berrange (berrange@xxxxxxxxxx) wrote:
> +     default:
> +             if (major > 202) {
> +                     minor += (16 * 16 * (major - 202));
> +                     major = 202;
> +             }
> +     }

I didn't think of handling overflow (since the major for scsi/ide/etc
were involved, I expected that to fail).  But, aside of crashing an
older guest with > 16 disks (not ideal, but I think it's possible
already with 0x format), seems good.

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel