WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Why call iommu_unmap_page() in set_p2m_entry()?

To: "Wei Wang2" <wei.wang2@xxxxxxx>
Subject: RE: [Xen-devel] Why call iommu_unmap_page() in set_p2m_entry()?
From: "Han, Weidong" <weidong.han@xxxxxxxxx>
Date: Wed, 19 Mar 2008 09:06:55 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 18 Mar 2008 18:12:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1205861385.18682.47.camel@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <08DF4D958216244799FC84F3514D70F00124FB6E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1205861385.18682.47.camel@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AciJHdTT4/pSsZsHQOqe87UIzqMk+wAPycCQ
Thread-topic: [Xen-devel] Why call iommu_unmap_page() in set_p2m_entry()?
Hi Wei,

I missed something of your code. Now I understand, it's no problem. The
operation can be generic. Thanks!

Randy (Weidong)

Wei Wang2 wrote:
> Hi Weidong,
> Thanks for pointing it out.  iommu_unmap_page() is not intended for
> flushing all iotlb entries. As AMD-IOMMU also supports
> domain-selective unmapping and I seem to find related functions in
> vtd code,I hope this operation can also be generic. If not, I plan to
> put this into amd specific functions called by domain destroy
> routines. 
> 
> Wei
> 
> On Thu, 2008-03-13 at 14:28 +0100, Han, Weidong wrote:
>> As my understanding, AMD IOMMU doesn't share its page tables with p2m
>> table. So it needs call iommu_unmap_page() to free pages when shut
>> down or destroy domain. Now iommu_unmap_page() is only called in
>> set_p2m_entry(), I think it won't be executed when shut down or
>> destroy domain. I'm not familiar with AMD IOMMU code, maybe I missed
>> something. Can you explain why do that? Thanks!
>> 
>> Randy (Weidong)
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>