[Xen-devel] netfront leaking two pages on unload?

[Andy Grover <andy.grover@xxxxxxxxxx>]

Hi all,

It appears netfront is leaking 2 pages (info->tx.sring and rx.sring) on
netfront unload, because netback is not unmapping them when entering the
Closed state.

I came across this while working on the Windows Xennet driver unload
routines. I am trying to end access to those two pages after both
netfront and netback are in the "Closed" state (having passed through
"Closing") but they are still in use.

See below from netback/xenbus.c. Backend is online:

case XenbusStateClosed:
        xenbus_switch_state(dev, XenbusStateClosed);
        if (xenbus_dev_is_online(dev))
                break;
        /* fall through if not online */

Should it instead be:

case XenbusStateClosed:
        if (xenbus_dev_is_online(dev)) {
                struct backend_info *be = dev->dev.driver_data;
                netif_disconnect(be->netif);
                break;
        }
        xenbus_switch_state(dev, XenbusStateClosed);
        /* fall through if not online */

?

Otherwise the pages cannot be freed properly in the guest, right?

Thanks -- Regards -- Andy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel