Re: [Xen-devel] Is Xend versioned?

[Mark Williamson <mark.williamson@xxxxxxxxxxxx>]

> When querying Xend for version this code is invoked in
> tools/python/xen/xend/XendNode.py
>
>     def xen_version(self):
>         info = self.xc.xeninfo()
>
>         try:
>             from xen import VERSION
>             info = {'Xen': '%(xen_major)d.%(xen_minor)d' % info,
>                     'Xend': VERSION}
>         except (ImportError, AttributeError):
>             info = {'Xen': '%(xen_major)d.%(xen_minor)d' % info,
>                     'Xend': '3.0.3'}
>
> I cannot find a xen module from which to import VERSION, resulting in
> the hardcoded one.  I would cook up a patch if I understood how, or even
> if, it should be versioned.

You're right, I can't see what this is supposed to achieve...

If you were to add:

VERSION = "blah"

to tools/python/xen/__init__.py

then I imagine that would do the right thing.  As for whether it's necessary, 
I'm not sure...  But presumably that code ought either to do something or to 
be removed???

Cheers,
Mark


-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel