WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make xendomains ignore lost+found

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make xendomains ignore lost+found
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Fri, 29 Jun 2007 17:13:59 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxxxxxxxx>, Gawain Lynch <gawain.lynch@xxxxxxxxx>
Delivery-date: Fri, 29 Jun 2007 09:12:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200706291658.18911.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <a719f8720706282236x3d0b9ed9m1c5447a1e8ce77c7@xxxxxxxxxxxxxx> <200706291658.18911.mark.williamson@xxxxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Jun 29, 2007 at 04:58:18PM +0100, Mark Williamson wrote:
> > As requested by Mark Williamson in BZ #681
> >
> > Signed-off-by: Gawain Lynch <gawain.lynch@xxxxxxxxx>
> 
> Gawain, thanks for identifying this and patching it.
> 
> This fixes a breakage on resume when the XENDOMAINS_SAVE directory is a 
> separate partition.
> 
> At some point it /might/ be nice to have more sophisticated checking of what 
> is an suspend image, and what's not.  But this patch shouldn't break 
> anything, and should fix a user-visible bug for some people.

You can read the first 16 bytes of the file & check they are 'LinuxGuestRecord'.
This is the sanity check we do in virt-manager when user asks us to restore
a VM from saved image.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>