WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating ins

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 19 Jun 2007 10:59:55 +0100
Delivery-date: Tue, 19 Jun 2007 02:58:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4677C3AE.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceyWJYw1PSoyh5LEdyOfAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] x86: clear guest's EFLAGS.RF after emulating instructions
User-agent: Microsoft-Entourage/11.3.3.061214
On 19/6/07 10:53, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

You set EFLAGS.RF in a few places when injecting #PF. Why would you do that?
It isn't Xen's job to set that flag ever afaics, and since the original trap
into Xen was not due to #DB you're not avoiding an infinite loop.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel