WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 11 Jun 2007 18:12:22 +0800
Delivery-date: Mon, 11 Jun 2007 03:10:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C292DDB6.10671%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceW+19nrz3vWNtATFekqBOc/y2imQVFRs2KAAACwLA=
Thread-topic: [Xen-devel] [PATCH 1/12] Add suspend/resume to devices owned by Xen
>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>Sent: 2007年6月11日 18:09
>On 15/5/07 15:14, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>> +    now = get_cmos_time();
>> +    sleep_diff = now - sleep_start;
>> +    wc_sec = now;
>> +    jiffies += sleep_diff * HZ;
>> +
>> +    stime_platform_stamp += SECONDS(sleep_diff);
>
>Is this correct? I think you should either increment wc_sec by sleep_diff,
>*or* increment stime by SECONDS(sleep_diff). If you do both, wall clock
>will
>jump by twice the amount it should have done, won't it (because wc_sec
>is
>wallclock time when stime=0)?
>
> -- Keir

You're right that wc_sec shouldn't be updated. I have a patch pending 
in house to fix it actually, but wait for right time to submit. :-) Thanks for 
review and sorry for no notification earlier.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>