WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support

To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 06 Jun 2007 09:34:27 +0200
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, lkml <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Benjamin LaHaise <bcrl@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>
Delivery-date: Wed, 06 Jun 2007 00:31:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070522141252.611887616@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070522140941.802382212@xxxxxxxx> <20070522141252.611887616@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>--- a/arch/i386/xen/time.c
>+++ b/arch/i386/xen/time.c
>@@ -105,17 +105,15 @@ static void get_runstate_snapshot(struct
>       preempt_enable();
> }
> 
>-static void setup_runstate_info(void)
>+static void setup_runstate_info(int cpu)
> {
>       struct vcpu_register_runstate_memory_area area;
> 
>-      area.addr.v = &__get_cpu_var(runstate);
>+      area.addr.v = &per_cpu(runstate, cpu);
> 
>       if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
>                              smp_processor_id(), &area))

Shouldn't this be 'cpu' rather than 'smp_processor_id()'?

>               BUG();
>-
>-      get_runstate_snapshot(&__get_cpu_var(runstate_snapshot));
> }
> 
> static void do_stolen_accounting(void)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>