Re: [Xen-devel] [PATCH] [Xen] [ACM] Code restructuring

To:	Stefan Berger <stefanb@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] [Xen] [ACM] Code restructuring
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Tue, 24 Apr 2007 21:33:20 +0100
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Tue, 24 Apr 2007 13:30:32 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<OF609DF100.80F87724-ON852572C7.0059295D-852572C7.0059458B@xxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AceGr8vNCqcAlvKjEduiCgAWy6hiGQ==
Thread-topic:	[Xen-devel] [PATCH] [Xen] [ACM] Code restructuring
User-agent:	Microsoft-Entourage/11.3.3.061214

On 24/4/07 17:15, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> Much nicer, thank you. I've applied it for 3.0.5. However, given the effort
> put in to labelling a domain at the very start of its lifetime, wouldn't it
> be a good idea to leave that label attached until the domain is actually
> destroyed? This would correspond to putting the destructor call in
> domain_destroy() or, even better, complete_domain_destroy(). Bear in mind
> that a domain may still be accessible and have resources allocated to it
> even after domain_kill() finishes executing. So stripping its resource label
> at that point in time is a bit worrying.

Right. Can you move this one call into complete_domain_destroy()?

Will do.
K.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] [Xen] [ACM] Code restructuring