WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] [libxc] add missing free in xc_finish_mmu_update

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] [libxc] add missing free in xc_finish_mmu_updates to avoid memory leak
From: Stephan Creutz <stephan.creutz@xxxxxxxxxxxxxxxxx>
Date: Wed, 11 Apr 2007 16:55:28 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 11 Apr 2007 07:54:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C23EB541.589C%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070408141436.15abe89f.stephan.creutz@xxxxxxxxxxxxxxxxx> <C23EB541.589C%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, 08 Apr 2007 15:05:37 +0100
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:

> On 8/4/07 13:14, "Stephan Creutz" <stephan.creutz@xxxxxxxxxxxxxxxxx>
> wrote:
> > I'm trying to develop a fast rollback for domains without recreating
> > the whole domain. In some cases I need to update pagetables to
> > restore an older memory state from a checkpoint. Maybe I should
> > integrate it in libxc itself to avoid code duplication. But I
> > thought it would be better to start with an external tool because my
> > rollback is very special. It uses the shadow pagetables all the time
> > to track dirty pages. Shadow pagetables are slow, so it might not be
> > useful for other users.
> 
> I'm not sure whether this will work. It's not possible to modify
> another domain's page tables if Xen is currently type-tracking the
> page tables as such. You'd have to modify Xen to be able to do that.

Ok, thought a little bit about that. If I modify Xen in way that foreign
pagetable updates from Dom0 are possible, would this change will ever
have a chance to be accepted for Xen or is it against the general design
principles of Xen? Or in other words: is it not implemented because no
one needs that feature for now or because it is not wanted for any
reason? All I try to prevent are external patches, which I have to adapt
every time the Xen internals are changing.

Stephan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel