WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Proper use of VMX execution controls MSR.

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Proper use of VMX execution controls MSR.
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 29 Mar 2007 10:11:58 +0100
Delivery-date: Thu, 29 Mar 2007 02:11:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <B30DA1341B0CFA4893EF8A36B40B5C5DF223D5@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdxUQOcmZ2ehsIdTvOT1iiVu1vOEgAEiiMSAA+9sZAADN/eOAAAdMgwAAK1/kQ=
Thread-topic: [Xen-devel] [PATCH] Proper use of VMX execution controls MSR.
User-agent: Microsoft-Entourage/11.2.5.060620


On 29/3/07 09:37, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> if we have the feature support in Xen, we should set the input control
> bit, and expect the adjusted value to be 1;
> if we don't have the feature support in Xen, we should clear the input
> control bit, and expect adjusted value to be 0;
> That's meaning the adjusted output is determined by the input control.
> So the expression should be "AND (msr_hi XOR msr_lo)".

The subsequent AND with msr_hi and the OR with msr_lo has exactly the same
effect. So the AND (msr_hi XOR msr_lo) is not incorrect, but it is
redundant.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel