[Xen-devel] non-ANSI Unions

[PUCCETTI Armand <armand.puccetti@xxxxxx>]

Many "unions' are present in the code, but are non-ANSI!

For instance, I see:

struct page_info
{
   /* Each frame can be threaded onto a doubly-linked list. */
   union {
       struct list_head list;
       /* Shadow uses this field as an up-pointer in lower-level shadows */
       paddr_t up;
   };
   /* Reference count and various PGC_xxx flags and fields. */
   u32 count_info;
...}

which should be written properly:

struct page_info
{
   /* Each frame can be threaded onto a doubly-linked list. */
   union {
       struct list_head list;
       /* Shadow uses this field as an up-pointer in lower-level shadows */
       paddr_t up;
   } foo;

   /* Reference count and various PGC_xxx flags and fields. */
   u32 count_info;
...}

Is there any good reason to do so? Is it possible to change that, to 
comply with the standard
(and therefore with analysis tools too) ?

Armand


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel