WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Error in XendCheckpoint: failed to flush file

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Error in XendCheckpoint: failed to flush file
From: Stefan Berger <stefanb@xxxxxxxxxx>
Date: Wed, 28 Feb 2007 16:18:21 -0500
Cc: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Wed, 28 Feb 2007 13:17:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C20B785F.A5B1%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx wrote on 02/28/2007 01:20:15 PM:

> On 28/2/07 18:07, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:
>
> > OK. Do you think it's worth checking the fd type with stat and only
> > doing the flush/fadvise if it's not a socket?
>
> My guess is probably not. I think fsync/fadvise/lseek are all well-defined
> to fail without trashing things if passed a socket. There's no reason to
> suspect that doing a stat() will be any quicker than just letting the
> fsync() or fadvise() fail.
>
> I've checked in some cleanups in this area as c/s 14176:d66dff0933.
> Hopefully it'll be in the public tree rsn, assuming I've fixed save/restore
> sufficently well!


All the xm-test that I reported that weren't working before are working now. Thanks.

   Stefan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel