WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] xendomains init script

To: Xen development list <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] xendomains init script
From: Florian Kirstein <xenlist@xxxxxxxxxxxxxx>
Date: Wed, 28 Feb 2007 18:26:00 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Wed, 28 Feb 2007 09:25:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C20B477B.A54F%keir@xxxxxxxxxxxxx>; from keir@xxxxxxxxxxxxx on Wed, Feb 28, 2007 at 02:51:39PM +0000
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070228062023.D27835@xxxxxxxxxxx> <C20B477B.A54F%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.2.5.1i
Hi,

> Or does that not work?
Exactly. The LSB way does not work on Redhat-based distributions prior
to RHEL5. And that's not /really/ a RH bug, as LSB explicitly allows their
alias implementation, which unfortunately can't be used the way the script
tries to. Really a silly problem caused by the LSB spec allowing aliases.

> Why is the LSB case moved to after the RedHat case? LSB looks like a more
> specific check (it looks for a file with 'lsb' in the path for a start!)
No, LSB is the most generic check, as most distributions have LSB
compliance scripts today. As the script's first check is for SUSE's
/etc/rc.status, it's only logical to check for RedHat's /etc/init.d/functions
second, and only then go for the generic case, LSB. Especially as that
doesn't work on all current RedHat's and causes
/etc/rc.d/init.d/xendomains: line 67: log_success_msg: command not found
errors turning up in all (Fedora, Redhat) bugzillas :)

I don't see any non-redhat Distribution having an /etc/init.d/functions
(which does not implement the RH success and failure function), so it should
cause no problem to move this up, but it will make the problem disappear on
all RH and Fedora Versions out there. And as RHs old LSB implementation
isn't a bug (according to the spec), we have to fix our init script and can't
hope for fixes in older Fedora/RedHat's LSB. See my post last year...

(:ul8er, r@y

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>